Skip to content

Revert 1798 feature/elementwise checks part 2 #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rok-cesnovar merged 4 commits into from
Jul 25, 2020
Merged

Revert 1798 feature/elementwise checks part 2 #1984

rok-cesnovar merged 4 commits into from
Jul 25, 2020

Conversation

@bbbales2
Copy link
Member

@bbbales2 bbbales2 commented Jul 24, 2020 •
edited
Loading

Summary

Adding some missing tests

Fixes #1983

Tests

The check_finite tests were missing tests for std::vector<std::vector<T>> which is why #1641

Release notes

Added missing tests to check_finite

Checklist

  • Math issue Missing check finite tests #1983

  • Copyright holder: Columbia University

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)

  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@stan-buildbot
Copy link
Contributor

stan-buildbot commented Jul 25, 2020

Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.91 3.99 0.98 -2.12% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 1.0 -0.0% slower
eight_schools/eight_schools.stan 0.09 0.1 0.95 -5.21% slower
gp_regr/gp_regr.stan 0.19 0.19 1.0 0.47% faster
irt_2pl/irt_2pl.stan 5.33 5.31 1.0 0.36% faster
performance.compilation 86.5 85.48 1.01 1.18% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.57 7.57 1.0 0.03% faster
pkpd/one_comp_mm_elim_abs.stan 26.77 27.17 0.99 -1.49% slower
sir/sir.stan 114.3 114.6 1.0 -0.26% slower
gp_regr/gen_gp_data.stan 0.04 0.04 0.98 -2.2% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.99 2.99 1.0 -0.11% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.38 0.4 0.96 -3.96% slower
arK/arK.stan 1.73 1.73 1.0 -0.26% slower
arma/arma.stan 0.62 0.59 1.05 4.42% faster
garch/garch.stan 0.6 0.6 1.0 -0.36% slower
Mean result: 0.994143573773

Jenkins Console Log
Blue Ocean
Commit hash: 54fd022

Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

rok-cesnovar
rok-cesnovar approved these changes Jul 25, 2020
View reviewed changes
Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rok-cesnovar rok-cesnovar merged commit 3c548a9 into develop Jul 25, 2020
@rok-cesnovar rok-cesnovar deleted the revert-1798-feature/elementwise_checks_part_2 branch July 25, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rok-cesnovar rok-cesnovar rok-cesnovar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing check finite tests

5 participants

@bbbales2 @stan-buildbot @rok-cesnovar @yashikno